Closed Maartenvm closed 7 years ago
the import './QueryClearButton.css' should be lowercase file name
the import './QueryBuildButton.css' should be lowercase file name Already fixed, noticed it too today.
there's commented out code in a couple of places...a code smell Can probably be deleted now.
the search functionality seems broken, at least when I type Agent
nothing happens (visualliy at least)
Works for me... did you update the server you're using to the "add_trigger" branch?
for the record, the veritcal alignment of tree element is not working corretly, but I guess we knew that already. something to do with interaction between React and material design (and superfluous divs)
did you intend to merge back into jhs-reactify? Yes, since this needs to be merged into your code before we can merge all of this back into the master branch
about query-builder-server:
about query-builder-daemon:
I think we should invest some time into writing some documentation.
The master branch of server should work, but it might have been missing a database file in the last commit. I commited just now a version thats working on my machine so ... try again?
The daemon is not strictly necessary to test the client (yet) but that should also work. You do need to change the paths in scripts/storyteller.sh to suit your installation though and install tthe cltl/Storyteller app beside it, so thats rather annoying too. (yes the hardcoded paths are terrible... ask Jason)
good job intergrating the tree stuff with the rest.
couple of things I noticed:
Agent
nothing happens (visualliy at least)