search

NLeSC-Storyteller / query-builder-client

A Query builder to query the Knowledge Store and generate datafiles that can be visualized with the Storyteller interface.
Apache License 2.0
0 stars 1 forks source link

source maps broken #8

Closed jspaaks closed 7 years ago

jspaaks commented 7 years ago

at least they don't go back to the TS, just the ES6.

jspaaks commented 7 years ago

possible solution is described here https://github.com/facebookincubator/create-react-app/issues/343

jspaaks commented 7 years ago

So I just tried it out with 'cheap-module-source-map' instead of 'eval'. In-browser debugging now goes back to the written code as opposed to generated code. It remains to be seen if any of the issues raised facebookincubator/create-react-app#343 will be confusing.

I changed line 40 of node_modules/@nlesc/react-scripts/config/webpack.config.dev.js from 

  devtool: 'eval',

to 

  devtool: 'cheap-module-source-map',

this will be the default for react-scripts@v0.8.0 anyway.

jspaaks commented 7 years ago

works with the fix above. closing.