Enable tslint rules that require typecheck

NLeSC / create-react-app

Create React apps with no build configuration.

Other

1 stars 1 forks source link

Enable tslint rules that require typecheck #23

Closed sverhoeven closed 7 years ago

sverhoeven commented 7 years ago

The following rules have been disabled:

"no-for-in-array": false,
"restrict-plus-operands": false,

As these require type-check and type-check has not been enabled for tslint.

We would like to enable these rules.

Maartenvm commented 7 years ago

Is not fixed unfortunately. "npm start" gives errors about rules that require type checking

sverhoeven commented 7 years ago

The webpack-tslint package does want work with typeCheck: true . Also the plugin linter-tslint in Atom and tslint in VSCode dont implement type check.

So will disable the rules again and disable the typecheck in npm run lint.

sverhoeven commented 7 years ago

Published packages Changes:

@nlesc/react-scripts: 0.1.0 => 0.1.1
@nlesc/tslint-config-react-app: 1.1.0 => 1.1.1