search

NLeSC / create-react-app

Create React apps with no build configuration.
Other
1 stars 1 forks source link

Merge facebook v0.8.5 #47

Closed sverhoeven closed 7 years ago

sverhoeven commented 7 years ago

Our master branch was forked from facebookincubator/create-react-app on 1 Nov 2016. In this branch the changes of the facebookincubator/create-react-app v0.8.5 tag have been merged.

This branch should be tested by generating apps with npm and yarn and at least test all the npm commands and verify the test coverage still works.

sverhoeven commented 7 years ago

For me the following commands work correctly:

create-react-app --scripts-version=@nlesc/react-scripts test-app
cd test-app
npm start
npm run build
CI=1 npm test
CI=1 npm test -- --coverage

Added code in 100% covered file, which cause coverage to drop.

Also tested with yarn by installing it with npm install -g yarn and running the same commands as above with npm replaced with yarn.