NLeSC / enram

Apache License 2.0
5 stars 10 forks source link

no STDEVBIRD check when converting reflectivity to bird density #70

Closed jspaaks closed 9 years ago

jspaaks commented 9 years ago

Would it be possible to manage including/excluding of certain gates based on another flag using the includeGate() and classifyGatesSimple() methods?

Question @adokter: what does it this check do conceptually?

adokter commented 9 years ago

Indeed this is the right place to add it, however you need output from svdfit that is now coded only at a later stage.

The following steps are needed:

  1. Take the chi that you calculate here for iProfileType==3.
  2. When you calculate the bird density here for iProfileType==1 , all bird densities should be set to zero when chi<STDEVBIRD.

Conceptually, this is the most important classification step between birds and particles passively tracing the wind field, such as most insects and precipitation. Only birds cause a high chi.

jspaaks commented 9 years ago

Here's what I propose. I'll change the program to always calculate 3 profiles but in a different order: 3, 2, 1 rather than 1, 2, 3. When I'm calculating iProfileType==3, I can fill an int array list with nLayers elements, with either TRUE or FALSE values, depending on the result of chi<STDEVBIRD. This array can then later be used when processing iProfileType==1. Sounds good?

adokter commented 9 years ago

Sounds good!

jspaaks commented 9 years ago

Fixed in commit c4276ed2243dc62c188e4607f8ad1ff33d073037. Closing the issue.