search

NLeSC / python-template

Netherlands eScience Center Python Template
https://research-software-directory.org/software/nlesc-python-template
Apache License 2.0
164 stars 74 forks source link

Update python versions in CI matrix: -3.6, +3.10, +3.11 #329

Closed sjvrijn closed 1 year ago

sjvrijn commented 1 year ago

Description Adds python 3.10 and 3.11 to the test matrix.

Related issues:

egpbos commented 1 year ago

Oh dear, looks like CI is quite broken. Not your fault, but that makes it hard to review this...

BSchilperoort commented 1 year ago

Oh dear, looks like CI is quite broken. Not your fault, but that makes it hard to review this...

From a quick search it seems to me this has to do with the pytest version being pinned to <5.0.0. The last update to 4.x was almost 3 years ago.

https://github.com/NLeSC/python-template/blob/807f751c2ce759e6e3464f714f2ef69929858f7e/setup.cfg#L45

Tests of 3.7, 3.8 and 3.9 fail because of pyroma.

setup.py
  Line: None
    pyroma: PYRUNKNOWN / You should specify what Python versions you support with the 'requires-python'/'python_requires' metadata.
egpbos commented 1 year ago

Thanks @BSchilperoort! Let's just remove the upper and lower limits then for pytest. The pyroma check should be fixed by adding python_requires = >=3.7 under [options] in setup.cfg, I think.

egpbos commented 1 year ago

Argh Schermafbeelding 2023-01-30 om 11 31 11

sjvrijn commented 1 year ago

I'm finding all the interesting ways to break the CI it seems 😂

egpbos commented 1 year ago

I guess the easiest fix here is to just wait two days for the (hopefully monthly) budget to be reset.

egpbos commented 1 year ago

Well, actually you could try forking the repo and making the PR and running CI there to circumvent the nlesc org limits :)

egpbos commented 1 year ago

All green, except the Windows builds, but that's already a separate issue: #326. Good to go!