search

NLeSC / python-template

Netherlands eScience Center Python Template
https://research-software-directory.org/software/nlesc-python-template
Apache License 2.0
164 stars 74 forks source link

run CI only on push/PR to main #330

Closed sjvrijn closed 1 year ago

sjvrijn commented 1 year ago

Description As noticed by @BSchilperoort, the CI currently runs twice when new commits are pushed to a PR. This can be limited to only run on the main branch itself or PRs to main.

egpbos commented 1 year ago

This is great, thanks!

One small additional request: could you perhaps remove the line with types: [opened, synchronize, reopened]? It is superfluous, because those types are already the default (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request).

Ready to merge after that, afaic.

egpbos commented 1 year ago

Oh, actually, the markdown-link-check action has the same issue... Would be super nice if that was fixed too :D

sjvrijn commented 1 year ago

Should the cffconvert then also be limited to only run on push/PR to main?

egpbos commented 1 year ago

No cffconvert is already very specific, only runs when the cff file is updated.

Lgtm!

egpbos commented 1 year ago

Thanks for both these great PRs!