Closed sjvrijn closed 9 months ago
This is a great PR, thanks for this effort!
One additional change to a src
-based layout would make this even better, since it would simplify configuration (see my comments). Do you have time for this? If not, I think we can merge after taking @gcroci2's suggestions into account and then make a new issue/PR for moving to src
-based.
Thanks for the feedback @egpbos and @gcroci2, the PR has been updated.
Given the difficulties already indicated in #173, I've chosen to keep the move to an src
setup to a separate PR that I'll work on next.
@gcroci2 good catch! downside of making a typo during a 'find & replace all' 😅
@sjvrijn great stuff, keep it coming! 😄 Be aware that the failure with >=3.9 is already fixed in #347.
@egpbos All other tests are now fixed, I'll merge this after #347 (and #353? I guess)
Ok, both other PRs are merged. There are some merge conflicts left to fix. Also, I was wondering: you now invoke -m build
instead of setup.py
, but doesn't that actually need build
installed as a dependency (as @gcroci2 earlier suggested, see https://github.com/NLeSC/python-template/pull/352#discussion_r1347001242)?
Finally, if you are up for becoming a true UGHist, I warmly invite you to squash some of the commits (happy to do it together, I'm at the office tomorrow), but no worries if you don't have the time 😁
@egpbos Yep, I indeed had to include build
to enable the sdist
build according to this StackOverflow question. Unless there's another way you know of?
Also, UGH challenge accepted 💪 I've rebased my commits on top of the merged main, and fixup
ed some of the corrective commits into the first one.
UGH! Super nice addition, thanks!
Description
setup.py
andsetup.cfg
pyproject.toml
Some minor adjustments made during the translation:
>=64.0.0
tosetuptools
under[build-system]
: this is the first version to add support for PEP660: Editable installs for pyproject.toml based buildszip_safe
settinginclude-package-data = true
under[tool.setuptools]
in combination with requiringsetuptools-scm
. This automatically adds all data files that are included under source control.packages = {{ cookiecutter.package_name }}
under[tools.setuptools]
repository_url
to define an https github url under[project.urls]
, since it wouldn't accept the git url incookiecutter.repository
:Related issues:
351
Instructions to review the pull request
Create a
python-template-test
repo on GitHub (will be overwritten if existing)