wrong links that point towards the github page of the new package

[f-hafner]

the template generates the wrong links for links that point towards pages inside the generated package. ie, instead of https://github.com/my-new-package/somepage, links are git@github.com:my-new-package/somepage.

See examples and fixes here: https://github.com/ivory-tower-private-power/sirup/commit/78249e2e66af6eafed55c5d4c8de070c3284f910 https://github.com/ivory-tower-private-power/sirup/commit/f34556842f9cfc026b895e62caa98601a7195b50

[egpbos]

Isn't that the SSH-based remote URL? Like this one:

[f-hafner]

yes, you're right, but I was not concise enough, sorry. I meant the links that point towards a website that are openend in a browser. For instance, the markdown link checker does not find this git@github.com:ivory-tower-private-power/sirup/issues, but only this https://github.com/ivory-tower-private-power/sirup/issues. I think some links in README.dev.md, CONTRIBUTING.md, and next_steps.md are affected.

[egpbos]

Ah ok, that's an issue indeed...

[sjvrijn]

Pip complained about this too when installing via pyproject.toml, so #352 includes a new repository_url cookiecutter variable for these cases.

[egpbos]

@sjvrijn does that solve this whole issue?

[sjvrijn]

@egpbos It will 🙂

[egpbos]

Since #352 was merged this should be fixed now. Please reopen if this is still an issue.