NLeSC / python-template

Netherlands eScience Center Python Template
https://research-software-directory.org/software/nlesc-python-template
Apache License 2.0
177 stars 76 forks source link

378b ruff config update dbodor #397

Closed DaniBodor closed 1 month ago

DaniBodor commented 2 months ago

Additional updates to ruff settings on top of #384.

Extra changes:

egpbos commented 1 month ago

384 merged, this can now be rebased on main.

egpbos commented 1 month ago

Damn, sorry for the sloppy review, but there is another ruff issue we missed in #384: in the build action, there is a linting workflow that also calls ruff .. That should become ruff check .. Can someone perhaps add a fix for that in this PR?

sjvrijn commented 1 month ago

Damn, sorry for the sloppy review, but there is another ruff issue we missed in #384: in the build action, there is a linting workflow that also calls ruff .. That should become ruff check .. Can someone perhaps add a fix for that in this PR?

@egpbos As far as I can tell, that's already in this PR, see build.yml

sjvrijn commented 1 month ago

@egpbos Issue was in the test, not the build.yml itself. Test are passing now. I've made the choice to ignore the newly raised issues in tests and docs/conf.py, but to add type hints to the sample package file rather than ignoring the type annotation issues all together. I think that making type checking optional and/or deferring to another tool like mypy should be a separate issue

DaniBodor commented 1 month ago

@egpbos , can this be merged now?

egpbos commented 1 month ago

Reviewer approved, so go for it :)