search

NLeSC / python-template

Netherlands eScience Center Python Template
https://research-software-directory.org/software/nlesc-python-template
Apache License 2.0
177 stars 76 forks source link

Find directory_name in copier #403

Closed lyashevska closed 1 month ago

lyashevska commented 1 month ago

Copier takes {{directory_name}} (=destination) as an input via copier copy source destination instead of asking user a question.

Following files refer to it:

./copier.yml
./tests/test_values.py
./template/README.md.jinja
./template/project_setup.md.jinja
./template/next_steps.md.jinja
./template/.github/next_steps/03_readthedocs.md.jinja
./template/.github/next_steps/01_sonarcloud_integration.md.jinja
./template/sonar-project.properties.jinja
./CHANGELOG.md
./setup.cfg
./README.md

Can we get away without directory name?

egpbos commented 1 month ago

I guess it sort of makes sense to not use the top-level directory name inside the repo, since anyway that can be changed by the user. You could replace it by a generic placeholder, or just assume (or suggest) that you are inside the repository root dir for all commands given. That could make some readme texts a bit esoteric though...

lyashevska commented 1 month ago

Fixed in #https://github.com/NLeSC/python-template/pull/411