NLeSC / python-template

Netherlands eScience Center Python Template
https://research-software-directory.org/software/nlesc-python-template
Apache License 2.0
180 stars 76 forks source link

Applying the template to existing code with tests creates dummy test files #578

Open maltelueken opened 3 weeks ago

maltelueken commented 3 weeks ago

The template creates the dummy test files tests/test_my_module.py, tests/test_values.py, and tests/test_projects.py when I apply it to code which already has tests in a tests/ folder. This is not really necessary I believe. Of course these files can be deleted, but users might accidentally commit them or forget to delete them.

fdiblen commented 2 weeks ago

Ref: #594

abelsiqueira commented 2 weeks ago

I think #594 is different. This issue is for when you have the local tests folder, and you probably want to say yes to having local tests. Saying no after #594 will prevent the issue, but won't solve for the general case.

On Bestie, all users have a test/runtests.jl file. That's the entry point to our equivalent to pytest. So it's predictable. Is it common to have some main test file, like tests/test_<package_name>.py, for instance?

PS. The other two files test_values.py and test_projects.py, don't seem to be present anymore.