NLeSC / python-template

Netherlands eScience Center Python Template
https://research-software-directory.org/software/nlesc-python-template
Apache License 2.0
196 stars 77 forks source link

Remove --fix from ruff tests and update template #634

Closed abelsiqueira closed 2 months ago

abelsiqueira commented 3 months ago

Checklist before requesting a review

Type of change

Please delete options that are not relevant.

List of related issues or pull requests**

Refs:

Describe the changes made in this pull request

Running ruff check should pass without the --fix option. This changes to test that verifies this and updates the files in the template that would cause the test to fail. Namely, some single-quoted strings were changed to double-quoted strings.

Instructions to review the pull request

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref <YOUR_BRANCH> https://github.com/nlesc/python-template test_package
# Create a local environment to test your generated package locally
python -m venv env
source env/bin/activate
python -m pip install --upgrade pip setuptools
python -m pip install '.[dev,publishing]'

Run the tests

pytest
abelsiqueira commented 2 months ago

Thanks for the review