Make code of conduct email conditional on AddCodeConduct - Githubissues

NLeSC / python-template

Netherlands eScience Center Python Template

https://research-software-directory.org/software/nlesc-python-template

Apache License 2.0

196 stars 77 forks source link

Make code of conduct email conditional on AddCodeConduct #644

Closed abelsiqueira closed 2 months ago

abelsiqueira commented 2 months ago

Checklist before requesting a review

[x] I have read the contribution guidelines
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

Refs:

534

Describe the changes made in this pull request

Move the code_of_conduct_email question to features_community.yml and only ask it if the user selected AddCodeConduct.

Instructions to review the pull request

Things to try:

Use the ask mode and check that the e-mail question is conditional on AddCodeConduct.

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref <YOUR_BRANCH> https://github.com/nlesc/python-template test_package