NLeSC / software.esciencecenter.nl

eStep website with projects software and people.
http://software.esciencecenter.nl
Other
4 stars 3 forks source link

Dafne #69

Closed dafnevk closed 8 years ago

dafnevk commented 8 years ago

Added pages for Dafne, Elena, and Salient region detectors.

blootsvoets commented 8 years ago

@elboyran could you review

elboyran commented 8 years ago

In the project description in _software I would use singular "Software package", not "packages" as it is now. Maybe also it's better to use "detector/detection" rather than "finding".

For the Salient Region Detectors page: What does status "wip" mean? I hope is the correct label. In the Description I would use "This package" instead of "These modules" (we aim to make it a Python package :-). And I would replace "software" in the third sentence with "package" as well. I think "for example" in the next sentence would be within commas (but am not a native speaker).

Would be nice to eventually link the package to publications. Is there such an option?

For the people's pages: for my page I would edit the last sentence: "Elena joined..." after "to work on" and replace the remainder of the sentence with "multidisciplinary projects with computer vision and machine learning components". Also from my page there should be a link to Biomarker boosting project!

Dafne's page: Would be nice to have a photo :-). A link not only to the Salient regions, but also to the protein's project?

dafnevk commented 8 years ago

The other comments I took care of. The branch now passes the validation.