search

NLincoln / ember-cli-ion-rangeslider

NO LONGER MAINTAINED An Ember and ion.RangeSlider integration, packaged as an Ember-cli addon.
MIT License
0 stars 1 forks source link

No default onChange #1

Open vlascik opened 7 years ago

vlascik commented 7 years ago

I'm trying to use your fork of rangeslider, but from and to values doesn't seem to be changed. I see that you removed the _sliderDidChange method and binding, and there's no default onChange method. How do you use it?

NLincoln commented 7 years ago

I've been using the onFinish event for awhile. It's very possible that the onChange binding is borked, I didn't fully test it :sweat_smile:. I can check it out tonight and probably get a fix out :+1:

vlascik commented 7 years ago

There's no default onFinish either, from and to aren't changed when dragging the slider... Having the ability to override these events is great, but there should be some default behavior perhaps?

NLincoln commented 7 years ago

Well, the entire reason I created this fork was that I needed to hook into the onFinish event for an application that relies on DDAU. One example of it's usage is this:

{{ember-ion-rangeslider
      min=min
      max=max
      type="single"
      grid=false
      step=1
      from=value
      hide_min_max=true
      onFinish=(action 'onchange')
}}

If you need to change the min and max, you'll want to change the values yourself in an action. I don't provide two-way data flow because doing so would break my use case for this fork