NLnetLabs / domain

A DNS library for Rust.
https://nlnetlabs.nl/projects/domain/about/
BSD 3-Clause "New" or "Revised" License
341 stars 57 forks source link

Fix brittle test #295

Closed ximon18 closed 4 months ago

ximon18 commented 4 months ago

An example failure can be seen here: https://github.com/NLnetLabs/domain/actions/runs/8659258392/job/23744751321#step:8:526

This PR explicitly terminates mock client connections during the test once they have received all of their responses, rather than leave them connected till the end of the test when the server shuts down. This hopefully helps with the net::server::tests::service_test which works fine locally but is brittle on GH Actions.

Result: 10 successful runs can be seen here: https://github.com/NLnetLabs/domain/actions/runs/8660164375