Fix compilation with feature zonefile by moving zonetree related functionality out of zonefile.

NLnetLabs / domain

A DNS library for Rust.

https://nlnetlabs.nl/projects/domain/about/

BSD 3-Clause "New" or "Revised" License

341 stars 57 forks source link

Fix compilation with feature zonefile by moving zonetree related functionality out of zonefile. #297

Closed ximon18 closed 4 months ago

partim commented 4 months ago

I wonder if it would be better to make zonefile::parsed::Zonefile the actual zone builder (i.e., replace zonetree::in_memory::ZoneBuilder with it? The two are closely connected, anyway. Merging them may make it less likely to build a broken tree?

ximon18 commented 4 months ago

The current division feels somewhat artificial so in that regard I concur. However, that is a much bigger change than a compilation fix so perhaps add it to the TODO list rather than make the change in this PR.

partim commented 4 months ago

Fair. How about just moving zonefile::parsed to zonetree::parsed? Having types like StoredDname in zonefile feels wrong to me.