NLnetLabs / domain

A DNS library for Rust.
https://nlnetlabs.nl/projects/domain/about/
BSD 3-Clause "New" or "Revised" License
345 stars 58 forks source link

Remove unnecesary cookie postprocessor handling. #301

Closed ximon18 closed 5 months ago

ximon18 commented 5 months ago

This code was causing a bug whereby duplicate COOKIE options would be added to the response, but with a change that happened to middleware recently the problematic logic became unreachable and can now be removed entirely.

Ideally the Stelline cookie test would be revived to verify this as well, but for now I've added a unit test, as reviving the Stelline test requires resolving the open issue about how to test with mock system clock time.

(and I tested manually using dig as well)