search

NLnetLabs / domain

A DNS library for Rust.
https://nlnetlabs.nl/projects/domain/about/
BSD 3-Clause "New" or "Revised" License
332 stars 56 forks source link

Minor fix for 0.10.0 #310

Closed xofyarg closed 2 months ago

xofyarg commented 2 months ago

Hi, I included two trivial changes when working on an upgrade from domain-0.7 to 0.10. Please let me know if I missed anything. Thanks.

partim commented 2 months ago

Thank you for the PR!

I am wondering if the type bitmap can ever be empty? Given that both RRSIG and NSEC(3) seem to be included in it, there should at least be the NSEC(3) record set?

Philip-NLnetLabs commented 2 months ago

The NSEC3 bitmap has all of the records present at the owner name, which is empty for an empty non-terminal.

partim commented 2 months ago

Ah, right. I suppose the PR can be merge, then.

xofyarg commented 2 months ago

I had the same question, and my colleague pointed me at this one:

... the NSEC3 RR exists because it corresponds to an empty non-terminal, in which case the NSEC3 RR will have an empty Type Bit Maps field

https://datatracker.ietf.org/doc/html/rfc5155#section-8.5