NLnetLabs / domain

A DNS library for Rust.
https://nlnetlabs.nl/projects/domain/about/
BSD 3-Clause "New" or "Revised" License
332 stars 56 forks source link

Re-enable and fix the Stelline cookies test #336

Closed ximon18 closed 4 weeks ago

ximon18 commented 1 month ago

PR #274 included a DNS cookies middleware processor and a corresponding Stelline .rpl test.

However, due to the mechanism to mock server time (needed to by the cookies rpl test) not being ready at that point the necessary support for the test was lacking so the test was merged to main in a disabled state (by renaming it to .not so that it was not included in the .rpl tests run by net::server::tests::server_tests().

Since then PRs #315 and #328 added the majority of the pieces that were missing making it possible for this PR to re-enable the Stelline cookies test and add further fixes & missing support to make all of its steps runnable and pass.

This PR also: