NLnetLabs / krill

RPKI Certificate Authority and Publication Server written in Rust
https://nlnetlabs.nl/projects/routing/krill/
Mozilla Public License 2.0
282 stars 38 forks source link

Fix aspa migration issues #1163

Closed timbru closed 8 months ago

timbru commented 8 months ago

@ximon18 improved the tests and fixed an issue so that 0.9.6 can be upgraded. Incidentally, 0.9.6 cannot be upgraded to 0.10.x if it has ASPA. But it can be upgraded to 0.14.3 (when this is merged and released).

ximon18 commented 8 months ago

@ximon18 improved the tests and fixed an issue so that 0.9.6 can be upgraded. Incidentally, 0.9.6 cannot be upgraded to 0.10.x if it has ASPA. But it can be upgraded to 0.14.3 (when this is merged and released).

When you say "cannot" - what happens if someone tries? And what happens if they try upgrading to 0.11.x instead of 0.10.x? Is it everything between 0.10.x and 0.14.2 inclusive that won't work in some way?

timbru commented 8 months ago

@ximon18 improved the tests and fixed an issue so that 0.9.6 can be upgraded. Incidentally, 0.9.6 cannot be upgraded to 0.10.x if it has ASPA. But it can be upgraded to 0.14.3 (when this is merged and released).

When you say "cannot" - what happens if someone tries? And what happens if they try upgrading to 0.11.x instead of 0.10.x? Is it everything between 0.10.x and 0.14.2 inclusive that won't work in some way?

If people used ASPA in 0.9.x, they can only upgrade to 0.14.3. This was not working in past versions.

If they did not use ASPA, then they could have updated to 0.10.x and above.

I tested that upgrades with ASPA from 0.10.3 to 0.11.0 to 0.12.1 to 0.13.1 work, and used the data dir after each of those upgrades in automated tests for upgrading to 0.14.3. I can manually test that on the test machine when I have a package for this PR.