search

NLnetLabs / ldns

LDNS is a DNS library that facilitates DNS tool programming
https://nlnetlabs.nl/ldns
BSD 3-Clause "New" or "Revised" License
295 stars 99 forks source link

Fix LOC centimetre parser to handle decimetres properly. #122

Closed FGasper closed 3 years ago

FGasper commented 3 years ago

Issue #121: Previously “0.1” was parsed as “0.01”; this fixes that.

FGasper commented 3 years ago

I’ve added a test but am unsure of the proper format for it; tpkg creates an archive, but the repo’s existing tests are all directories.

FGasper commented 3 years ago

It might be better to replace the cm parser with a hard-coded lookup, since there are only 100 possible numbers here. But this is a conservative fix.

wtoorop commented 3 years ago

Absolutely! Will merge with slightly modified test package so it gets called in the right moment.