NLnetLabs / ldns

LDNS is a DNS library that facilitates DNS tool programming
https://nlnetlabs.nl/ldns
BSD 3-Clause "New" or "Revised" License
292 stars 98 forks source link

Memory leak in ldns_dnssec_zone_new_frm_fp_l() #190

Open FGasper opened 1 year ago

FGasper commented 1 year ago

https://github.com/NLnetLabs/ldns/pull/186 adds memory-leak detection to the CI run, and it indicates a memory leak in this function.

What appears to be happening is that this duplicated record in 25-ZONEMD:

duplicate.example.  300 IN  TXT "I must be digested just once"

… is represented by 2 rr structs, only 1 of which gets assigned to the dnssec_zone. The other is never freed.

Zero3K commented 1 year ago

Will this be fixed soon?

FGasper commented 1 year ago

@Zero3K I think any fix would have to be pretty invasive. I could be wrong though.

wtoorop commented 1 year ago

I can have a look at this