search

NLnetLabs / ldns

LDNS is a DNS library that facilitates DNS tool programming
https://nlnetlabs.nl/ldns
BSD 3-Clause "New" or "Revised" License
285 stars 94 forks source link

Update python configuration, support platform site dir #204

Closed pemensik closed 1 year ago

pemensik commented 1 year ago

Update to the most recent ax_python_devel.m4 from autoconf-archive 2022.09.03. It reports two separate directories, one for platform independent files, another for platform specific files.

Make sure native code library installs into platform site directory. Python modules can be installed into common site directory. Should work on python 3.12, which removes distutils module completely.

Attempts to fix bug: https://bugzilla.redhat.com/show_bug.cgi?id=2155003

pemensik commented 1 year ago

Oh, the strange thing is update of ax_python_devel.m4 only has changed the destination directories from platform-specific to platform independent location. At least for _ldns.so this is clearly wrong. I am not sure where should those files belong. Perhaps it should be split into two separate commits. One with minimal only change supporting python 3.12, the second changing ldnsx module to be installed into platform independent directory, but ldns module and _ldns.so should be installed together to platform specific directory.

pemensik commented 1 year ago

Platform specific directory is okay according to RH bug comment 3. Therefore I removed split into python-only and platform directory. And keep just the most simple change building and installing it to the same place as before.

pemensik commented 1 year ago

This change is required to build with python 3.12. Is there anything needed? It is already as minimal as possible.

wtoorop commented 1 year ago

This change is required to build with python 3.12. Is there anything needed? It is already as minimal as possible.

Petr nothing, this looks like a clear fix. Thanks!

eli-schwartz commented 1 month ago

python 3.12 has been out for a while now, and this change is necessary to compile with it. Any news on tagging a new release? :)

wtoorop commented 1 month ago

Thanks. I will start working on a release very soon..