search

NLnetLabs / ldns

LDNS is a DNS library that facilitates DNS tool programming
https://nlnetlabs.nl/ldns
BSD 3-Clause "New" or "Revised" License
285 stars 94 forks source link

Bugfix/237 Resolver uses nameserver commented out in /etc/resolv.conf #238

Closed wtoorop closed 2 months ago

wtoorop commented 2 months ago

Fixed issue #237

grembo commented 2 months ago

Patch looks reasonable. I tested it for my limited use case and it works as expected.

dag-erling commented 2 months ago

Are you planning to merge this any time soon?

wtoorop commented 2 months ago

Are you planning to merge this any time soon?

Yes, I will merge it with Wouter's recommendation to add the comment

dag-erling commented 2 months ago

I don't think you fully appreciate the seriousness of this issue...

AlexanderBand commented 2 months ago

I don't think you fully appreciate the seriousness of this issue...

To manage expections around this free, open-source project, I'd like to note that unlike projects with production-grade support such as NSD and Unbound, work on ldns is done on a best-effort basis; for example in the context of a research project or an IETF Hackathon. We explicitly mention this in the development vision for the project.

dag-erling commented 2 months ago

To manage expections around this free, open-source project, [...]

You may want to consider your audience before you start handing out life lessons.

grembo commented 2 months ago

@AlexanderBand Just to make it clear: Your work on ldns is much appreciated.

I don't think you fully appreciate the seriousness of this issue...

To manage expections around this free, open-source project, I'd like to note that unlike projects with production-grade support such as NSD and Unbound, work on ldns is done on a best-effort basis; for example in the context of a research project or an IETF Hackathon. We explicitly mention this in the development vision for the project.

Maybe it would make sense to clarify the development vision, as the way it is currently written (quoting in full, emphasis is mine)

In principle we only perform basic maintenance and bug fixes on ldns, and will only consider development of new functionality on ad-hoc basis. This could for example be for a research project or an IETF Hackathon. We do not strive for ldns to be a comprehensive library that supports every (emerging) standard.

makes it sound (to me) like you would actually do bug fixes outside of research projects and IETF Hackathons. Using commented out parts of the configuration can have dire consequences, hence the sense of urgency.

AlexanderBand commented 2 months ago

Yes, we do bug fixes on ldns. Still, we're managing many projects with very limited resources. In the context of all reposnsibilities, ldns will not get the highest priority. I'm respectfully asking for your patience and understanding.

grembo commented 2 months ago

@wtoorop & @AlexanderBand Thank you!