Closed ngie-eign closed 2 months ago
This set of changes looks nice to me. Unbound has similar issues, because it has the same code in certain places, it needs the memory leak fix and some of the spelling fixes. I have created commits to the unbound code base to fix them, in https://github.com/NLnetLabs/unbound/commit/3cad5818a1b894415c3cd85987320e79717cf5c0 and https://github.com/NLnetLabs/unbound/commit/1974732d19229a6d885c2926db96e447590e5b86 .
This set of changes looks nice to me. Unbound has similar issues, because it has the same code in certain places, it needs the memory leak fix and some of the spelling fixes. I have created commits to the unbound code base to fix them, in NLnetLabs/unbound@3cad581 and NLnetLabs/unbound@1974732 .
Much appreciated! I looked at those PRs -- do I need to submit entries to the ChangeLog as well for the proposed changes, or is that something maintainers can handle?
Much appreciated! I looked at those PRs -- do I need to submit entries to the ChangeLog as well for the proposed changes, or is that something maintainers can handle?
I should be able to handle that :grin: . How would you prefer to be credited? As ngie-eign or with your full name. Cheers!
]
Much appreciated! I looked at those PRs -- do I need to submit entries to the ChangeLog as well for the proposed changes, or is that something maintainers can handle?
I should be able to handle that 😁 . How would you prefer to be credited? As ngie-eign or with your full name. Cheers!
Thanks! Could you please use my legal name (Enji Cooper) :)?
.gitignore
to ignore more build generated files.the the
->the
).