search

NLnetLabs / nsd

The NLnet Labs Name Server Daemon (NSD) is an authoritative, RFC compliant DNS nameserver.
https://nlnetlabs.nl/nsd
BSD 3-Clause "New" or "Revised" License
439 stars 102 forks source link

manpages contain unreplaced @date@ and @version@ #242

Closed janstary closed 2 weeks ago

janstary commented 1 year ago

Currently, all four manpages contain @date@ and or @version@, see the output of grep -E '@(date|version)' *.8{,.in}.

This shouldn't be there in the first place: a date is a part of the manpage itself, to be changed whenever someone changes the manpage; and nobody needs two versions of the same manpage installed.

Makefile creates *.8 from *.8.in by sed'ing the @variables@; but rather than adding @date@ and @version@ to the list, let's please remove these from the manpages.

janstary commented 1 year ago

https://github.com/NLnetLabs/nsd/pull/243

janstary commented 1 year ago

(Testing: it's @date not @date so why does github change that?)

janstary commented 1 year ago

@date not @date ; ah.

k0ekk0ek commented 1 year ago

Thanks @janstary! Please allow us to pick this one up once we've switched to Sphinx for generating man pages.

k0ekk0ek commented 2 weeks ago

I've added them to $(EDIT) in Makefile.in. makedist.sh the script we use to create releases actually does replace them. Anyway, the Makefile does so now too, closing this issue.