search

NLnetLabs / nsd

The NLnet Labs Name Server Daemon (NSD) is an authoritative, RFC compliant DNS nameserver.
https://nlnetlabs.nl/nsd
BSD 3-Clause "New" or "Revised" License
457 stars 103 forks source link

Official Docker Image #285

Closed nbish11 closed 2 months ago

nbish11 commented 1 year ago

What are your thoughts on adding docker support? Both Unbound and NSD would be great to have as officially maintained docker images and some of your other projects already have docker support. I have an example repository over at docker-nsd. I am more than happy to create a pull request and help to continue to maintain the image. (I would prefer to contribute here rather than have a separate fork.)

k0ekk0ek commented 1 year ago

Hi @nbish11! Thank you for bringing this to our attention. We'd love to add a reference in contrib for this, but prefer not to ship an official Docker image at this point. The reason for that is that there are too many configuration parameters and there's no one recommended way that is guaranteed to work for every user. Adding it to contrib is a good solution in situations like this. Issuing a PR against contrib/Docker (or similar) is probably the best way forward? Just adding a link to contrib/README.md is another possibility.

nbish11 commented 1 year ago

Thanks k0ekk0ek. I will open a PR against contrib a little later to close this issue.

Your not wrong about the config options. I've actually 'borrowed' your docker magic build technique from the krill library to allow NSD to be built for cpu or memory optimisation; as even for me, NSD needs to be built differently, depending on the project.

k0ekk0ek commented 2 months ago

Closing this issue.