NLnetLabs / routinator

An RPKI Validator and RTR server written in Rust
https://nlnetlabs.nl/projects/routing/routinator/
BSD 3-Clause "New" or "Revised" License
460 stars 70 forks source link

routinator_serial_info metric is sparse #941

Closed ties closed 6 months ago

ties commented 7 months ago

As a publication point operator I want to alert when my repository is not updating. For this I use an alert on the routinator_serial_info metric.

When doing so we sometimes hit a weird interaction between prometheus and this sparse metric, that we have worked around for now with a recording rule.

In practice this metric is sparse (it is empty when notification.xml is not modified). This causes increase alerts to fire (see the attached screenshots).

Expected behaviour: I expect routinator_serial_info to retain the old value when the notification file is not modified.

As discussed in DM with Martin: low priority/low impact, but nice to have.

preview

Screenshot_2024-03-08_at_08 35 46
partim commented 7 months ago

It’s a low priority/low impact kind of day today, so I just went ahead and fixed it …