Fix a first batch of review comments

NLnetLabs / simdzone

Fast and standards compliant DNS zone parser

BSD 3-Clause "New" or "Revised" License

63 stars 11 forks source link

Fix a first batch of review comments #169

Closed k0ekk0ek closed 5 months ago

k0ekk0ek commented 5 months ago

Intermittent failures due to segmentation faults witnessed on this PR are due to an issue with the runner-images.

k0ekk0ek commented 5 months ago

Failures in the MinGW build are related to disk access. Any tests failing in my personal build all have to do with generate_include in tests/syntax.c returning NULL nothing to do with the parser itself. (local MinGW builds all run fine and the exact same tests run fine when connected to GitHub Actions over SSH too).