search

NLnetLabs / simdzone

Fast and standards compliant DNS zone parser
BSD 3-Clause "New" or "Revised" License
63 stars 11 forks source link

Fix review comments #171

Closed k0ekk0ek closed 5 months ago

k0ekk0ek commented 5 months ago

Fix review comments by @wcawijngaards on #161

k0ekk0ek commented 5 months ago

@wcawijngaards, this should address all comments on #161, except for use of tmpnam. I agree that it's better to use a different function, and your suggestion would work, but determining the temporary directory cross-platform is a bit more involved. If you don't mind, I'd like to leave this for now and fix it later as the function is only ever used for testing.