NLthijs48 / AreaShop

A Bukkit/Spigot (Minecraft server) plugin that facilitates renting and buying WorldGuard regions
GNU General Public License v3.0
55 stars 89 forks source link

Signs cannot be put towards North. #607

Open MSitiSoftware opened 1 month ago

MSitiSoftware commented 1 month ago

Current behavior

Every time trying to put a sign for renting a shop it doesn't make the sign a For Rent sign. And when using commands for that purpose, it gives an error. This is a video that shows it: https://youtu.be/TMRcIC0AS80 The error being sent in the console is this:

[16:16:21 ERROR]: Could not pass event BlockPhysicsEvent to AreaShop v2.6.0
java.lang.NullPointerException: Cannot invoke "org.bukkit.block.BlockFace.getModX()" because "face" is null
        at org.bukkit.craftbukkit.v1_17_R1.block.CraftBlock.getRelative(CraftBlock.java:253) ~[patched_1.17.1.jar:git-Paper-408]
        at org.bukkit.craftbukkit.v1_17_R1.block.CraftBlock.getRelative(CraftBlock.java:248) ~[patched_1.17.1.jar:git-Paper-408]
        at me.wiefferink.areashop.features.signs.SignsFeature.onIndirectSignBreak(SignsFeature.java:120) ~[AreaShop.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor476.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.17.1.jar:git-Paper-408]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.17.1.jar:git-Paper-408]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.17.1.jar:git-Paper-408]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.world.level.Level.notifyAndUpdatePhysics(Level.java:683) ~[app:?]
        at net.minecraft.world.item.ItemStack.placeItem(ItemStack.java:415) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.server.level.ServerPlayerGameMode.useItemOn(ServerPlayerGameMode.java:601) ~[app:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItemOn(ServerGamePacketListenerImpl.java:1815) ~[app:?]
        at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.handle(ServerboundUseItemOnPacket.java:33) ~[app:?]
        at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.a(ServerboundUseItemOnPacket.java:9) ~[app:?]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:56) ~[app:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[app:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[app:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1426) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:192) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[app:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1404) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1397) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[app:?]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1375) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1286) ~[patched_1.17.1.jar:git-Paper-408]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Paper-408]
        at java.lang.Thread.run(Thread.java:842) ~[?:?]

Expected behavior Instead I of course expected the sign to be the functional For Renting sign of the specific Existing Shop region named shop14 that you can even see in the video that is there and existing.

Steps to reproduce

  1. Make a shop region / You need to have a shop region.
  2. Put a sign that faces North.
  3. Make him a Rent sign for the specific Shop Region you created/have.
    • Either by using /areashop addsign shop14
    • or typing [as] (or the signTag you configurated for add) at the first line, and then the shop region ID at second line.

Your environment

Your config files plugins.zip