search

NM-TAFE / dip-programming-prj-advanced-gui-awesome

Creative Commons Zero v1.0 Universal
0 stars 5 forks source link

Refactoring of remotellama #28

Closed rafrafavi closed 3 weeks ago

rafrafavi commented 1 month ago

Document this reference: https://github.com/NM-TAFE/dip-programming-prj-advanced-gui-awesome/blob/c831690b031c475c54b4fa094115f342456a0d34/app/remotellama.py#L6

Rename to remote_llama.py

Rename LlamaInterace class (should be good as just Llama)

Lastly, there is a very strange bastardization of Python's OOP mechanisms where standard methods are being used as pseudo-static methods, making the callers responsible for understanding this nuance.

This needs to be fixed by either adding self and requiring the callers to change as well, or, what might be easier, is to add staticmethod decorators to the methods since this is how they are used. From what I can tell, the latter method would not have impact on callers.

rafrafavi commented 1 month ago

When you submit the PR please get @bhandareasmita to review

Claire863 commented 1 month ago

Thanks Raf,

I am starting to work on it. Wont forget to include @bhandareasmita for the review.

rafrafavi commented 1 month ago

Don't forget to open a draft PR early and link to this issue