remotellama refactoring raise_for_status

NM-TAFE / dip-programming-prj-advanced-gui-awesome

Creative Commons Zero v1.0 Universal

0 stars 5 forks source link

remotellama refactoring raise_for_status #52

Closed Claire863 closed 3 weeks ago

Claire863 commented 3 weeks ago

@20095325

I see that you approved PR #29 (remotellama refactoring).

About the raise_for_status modification : Here if it fails, it will give a Traceback. Instead should we use a try / except to handle the error?

I don't know how to 'generate' an error and don't know how to test and write a code to handle it.

Would appreciate your thought on this.

Claire863 commented 3 weeks ago

To make it explicit, this is what I suggest / would appreciate your input :

20095325 commented 3 weeks ago

@Claire863 you could try changing the url to something that is incorrect and then try testing that way. We could maybe show something on the frontend that would indicate that the llama call failed