Dynamics loss should be -adv instead of adv? - Githubissues

NM512 / dreamerv3-torch

Implementation of Dreamer v3 in pytorch.

MIT License

422 stars 96 forks source link

Dynamics loss should be -adv instead of adv? #30

Closed truncs closed 1 year ago

truncs commented 1 year ago

https://github.com/NM512/dreamerv3-torch/blob/43e1b2ab889094e5bf4f1939a279cbb81486a90e/models.py#L443

Referencing the dreamerv3 official implementation

https://github.com/danijar/dreamerv3/blob/main/dreamerv3/agent.py#L295

truncs commented 1 year ago

Disregard, I see that it is negative further ahead,