NMAAHC / nmaahcmm

NMAAHC mm scripts
7 stars 8 forks source link

change handling of GENERAL cards #100

Open dericed opened 2 months ago

dericed commented 2 months ago

If the camera card type isn't identified then the camera cards script deviates from its usual behavior and adds this interview:

https://github.com/NMAAHC/nmaahcmm/blob/76946ca4f804dcabf9761c2ee0930bfd46e897f2/camera_cards#L418-L440

OK if I remove this part and simply proceed with the overall TAR/AIP settings?

chialinchou1 commented 2 months ago

Yes, I think we can remove "select a strategy" part, but should print to the screen that the Camera card type not identified. creating TAR/AIP....

dericed commented 2 months ago

I can use GENERAL as the fallback for an unidentified card. I was thinking, if the card is GENERAL, then we could find the most popular video extension in the card and just process those files.

chialinchou1 commented 2 months ago

That sounds good. So the TAR setting will just be an option. If no video files can be found/identified, we just logged it and get human interventions...

dericed commented 2 months ago

Ok, here's the update https://github.com/NMAAHC/nmaahcmm/commit/220b094f196ce4606252fccbd4ebc1dbdc9db81e