search

NMAAHC / nmaahcmm

NMAAHC mm scripts
7 stars 8 forks source link

Camera Cards: Invalid Option -c #40

Closed chialinchou1 closed 2 years ago

chialinchou1 commented 2 years ago

Hi @aeschweik,

  1. I tried to run the script with ./camera_cards -c but it's giving me the error message Invalid option -c and the help text. Am I using the command incorrectly?
  2. (carried over from previous issue) The syntax for checksum output should not have the file path, currently the one we're using is in this format: 7812f136273d0067c27d8a60375ae954 A025C071_1908055B_CANON.MXF_ffprobe.xml (the way its generated from makechecksum in NMAAHCmm)

Thanks for looking into these! Chialin

cc @BleakleyMcD

dericed commented 2 years ago

oops -c is documented in the usage function, but not evaluated in the argument processing

BleakleyMcD commented 2 years ago

@chialinchou1 @aeschweik is this still an issue?

dericed commented 2 years ago

Yes, this is still an issue, https://github.com/NMAAHC/nmaahcmm/blob/main/camera_cards#L38 defines the -c option but the options are processed without it at https://github.com/NMAAHC/nmaahcmm/blob/main/camera_cards#L49-L56. @aeschweik?

aeschweik commented 2 years ago

Hi @chialinchou1 (and @dericed), so sorry, you're totally right! This pull request should help: https://github.com/NMAAHC/nmaahcmm/pull/47. Let me know if it still doesn't work after that!

BleakleyMcD commented 2 years ago

@chialinchou1 pull request is merged. Thanks @aeschweik!