search

NMAAHC / nmaahcmm

NMAAHC mm scripts
7 stars 8 forks source link

camera_cards -N <parts> status? #85

Open chialinchou1 opened 5 months ago

chialinchou1 commented 5 months ago

@dericed

It concatenates only the video files selected, but all the camera original files are still being included in the final output.

BleakleyMcD commented 4 months ago

@dericed @chialinchou1 are we in agreement that the original files do not need to be included?

dericed commented 1 month ago

I added an option for this https://github.com/NMAAHC/nmaahcmm/commit/a65503a0d7caa8572e12ea7fe5928a5402143e2b

chialinchou1 commented 1 month ago

can it keep and sort only the selected parts?

dericed commented 1 month ago

so like if there's file1 file2 file3 garbage1 garbage 2, and you run -N 1,3 then it should keep file1 and file3 and the concatenation of file1 and file3?

chialinchou1 commented 1 month ago

If we are talking about files as all the non-video files that come with the card, then yes, it should keep file1 and file3 and the concatenation of video file1 and video file3. Current code does the concatenation but keeping all files (file1 , file2, file3, and I think it should only keep file 1 to 3, if possible...

dericed commented 1 month ago

Hi @chialinchou1 this should be addressed and done in https://github.com/NMAAHC/nmaahcmm/pull/102/commits/6f67bf72d5f0860e61abcaaf1dd8159cbe54d6d9

dericed commented 1 month ago

heya @chialinchou1 get a chance to test the recent stuff?

chialinchou1 commented 1 month ago

Yes! I did camera_cards -N 1-5 and camera_cards -N 6 -f mkv and they both work well for file sorting and concatenating. Thanks for making the changes @dericed

For camera_cards -N 6 -f mkv: is the 2024_50_2_concatenated_decoder_log.txt meant to be the same as the terminal output? The final messages didn't made it in to the text file? (see screenshot) Screenshot 2024-07-29

(see the log file here) (full report folders here)

Also the 2024_50_2_card_inventory.csv is the same regardless the parts selected, I supposed that's what we want.. thoughts @BleakleyMcD ?

Lastly, tested an AVCHD files (#98 ) and this report/log file was not generated? Will post on that issue.