search

NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.
https://nmf.earth
GNU General Public License v3.0
498 stars 156 forks source link

Add max width for chart container for big screens #200

Closed BatDroid closed 3 years ago

BatDroid commented 3 years ago

related to #111 Simulator Screen Shot - iPad Pro (11-inch) (2nd generation) - 2020-10-11 at 00 29 50

PierreBresson commented 3 years ago

@BatDroid humm it looks like it's breaking the current design (see pictures below)

Screenshot 2020-10-11 at 17 57 42 Screenshot 2020-10-11 at 17 58 30
BatDroid commented 3 years ago

I'm totally new to this app/repo. I can't see what is broken. could you explain it?

PierreBresson commented 3 years ago

@BatDroid no problem. If you have a look to the items Total, Transport and Food you will see that they are align center on your pr but not on master (cf screenshot that I've uploaded)

BatDroid commented 3 years ago

@BatDroid no problem. If you have a look to the items Total, Transport and Food you will see that they are align center on your pr but not on master (cf screenshot that I've uploaded) Thank you for the explanation here is the results: Simulator Screen Shot - iPad Pro (11-inch) (2nd generation) - 2020-10-12 at 01 10 08 Simulator Screen Shot - iPhone 11 - 2020-10-12 at 01 11 00

PierreBresson commented 3 years ago

@BatDroid thank you!

PierreBresson commented 3 years ago

oneplus Wrong rendering on android, revert changes