Fixing Issue 214:Design breaking for "Change" action and some code cleanup

NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.

https://nmf.earth

GNU General Public License v3.0

498 stars 156 forks source link

Closed ptbhatcoder closed 3 years ago

ptbhatcoder commented 3 years ago

The following changes are covered

Fixing the bug 214 - #214 by moving change to the next line
Adding the default language and default locale inside a constant for maintainability for language and locale
Changed multilevel ternary operator to if-else for readability, flexibility and maintainability
Wrapped one of the callbacks in useCallbacks to minimise re-renders
Added 2 utils to determine the earlier and the later dates and tests for them.
Updated snapshots

PierreBresson commented 3 years ago

@ptbhatcoder interesting pr, thanks 👍