search

NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.
https://nmf.earth
GNU General Public License v3.0
496 stars 156 forks source link

Update expo #250

Closed PierreBresson closed 3 years ago

PierreBresson commented 3 years ago

Update expo to sdk 40

petruspierre commented 3 years ago

Hey

Everything is working, we just need to decide a point. In the new version of the SDK it asks us to use @expo/vector-icons in version ^12.0.0 (currently we use 10.0.6).

If we did the update, we will have to update several icons that have changed their name or have been changed in Ionicons. (e.g. md-stats is now md-stats-chart)

The project still works using version 10.0.6, however, we will receive a warning every time when running expo start.

So should we leave it in the current version and open another Issue to solve the icons separately?

PierreBresson commented 3 years ago

Hello @petruspierre

As you want, if you want to update the icons you can do it in the same PR as the expo update, it shouldn't take long. Otherwise yes, it would be nice to have an issue to update the icons separately.