search

NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.
https://nmf.earth
GNU General Public License v3.0
496 stars 156 forks source link

Changes in the guides for some misspelling words #285

Closed adrnliaw closed 3 years ago

adrnliaw commented 3 years ago

✅ I have read the contributing file

Summary

I found some misspelling words for English language in the guides.json. Thus, I corrected those misspelling words.

Changelog

nmf-app\assets\guides\guides.json

The main changes are in this file in which I corrected all the misspelling that I found.

Demo

Firstly, I cloned the project into my disk and install dependencies using yarn and copied two files that contain secrets and replace them. Then, I tried to build the project with "yarn start" command. However, it failed due to dependencies issue. Therefore, I proceeded to installing necessary dependencies and build the project again, in which it turns out to be successful.

After that, I skim through the guides in the application and found some misspelling. Thus, I proceeded to correcting them.

After that, I tried to test the project. My first attempt in testing the project failed. Thus, I changed the "TZ=GMT jest" command in the test section of package.json file into "SET TZ=GMT && jest –runInBand -- forceExit" and try my second attempt in testing the project. The result was 302 out of 304 successful test and 2 snapshots failed. Then, I used the "yarn test -u" command to update the snapshot and get to pass all the tests. Then, I committed the project and push it to GitHub.

PierreBresson commented 3 years ago

@adrnliaw Thank for the pull request! 🙂