Fix test issues with jest and dates

NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.

https://nmf.earth

GNU General Public License v3.0

488 stars 157 forks source link

Fix test issues with jest and dates #294

Closed PierreBresson closed 2 years ago

PierreBresson commented 2 years ago

[ ] Currently tests need to be updated everyday because the date change in the snapshots, see this example.
[ ] There are issues with yarn test for some people, see pr292.

BatDroid commented 2 years ago

should we apply all the changes in PR for that?

PierreBresson commented 2 years ago

@BatDroid What do you mean exactly?

BatDroid commented 2 years ago

nothing. I guess I didn't see that You've merged the PR. shall I give it a try?

PierreBresson commented 2 years ago

@BatDroid if you have an idea on how to fix this issue, yes please, it's a bit annoying to have to update the tests everyday ^^

BatDroid commented 2 years ago

@PierreBresson Do you mind if I use this. I tested many things but a boilerplate code was the only way. I either can use the ugly boilerplate or use the mentioned package (which almost does the same thing). after all, it'll be in dev dependency. Give me an ok & consider it done :)

BatDroid commented 2 years ago

Also, I can add this workaround for the other issue. do you approve it?

PierreBresson commented 2 years ago

Yeap, the workaround and the MockDate sound good to me 👍