NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.
https://nmf.earth
GNU General Public License v3.0
488 stars 157 forks source link

New colors #313

Closed PierreBresson closed 1 year ago

PierreBresson commented 2 years ago

Summary

Bring all the colors of the design file in the app (see Colors.ts) and apply them in the different screens according to the design file.

thenicekat commented 2 years ago

Um, can you assign this to me so I can work on this...also is it okay if I submit my PR during october as it can count towards my hacktoberfest contribution Also from what I've understood I need to take colors from the first design file and add them to the colors.ts and then use them in the screens with ref from the second design file Is that right?

PierreBresson commented 2 years ago

Indeed, that's correct, pick colors from design file and replace colors with these new values. Then put these new colors everywhere in the app according to design file. Yeap, you can submit you pr anytime and then I will make sure to wait and merge it only the 1st of october so it counts for the event

thenicekat commented 2 years ago
  1. Also um can you give a sample as to how I replace colors in the app....like already some existing colors are there right?
  2. also this means the colors file will completely be replaced right?
  3. Also I knowledge about react but not much about react-native so can you tell me how to run the app to test it
PierreBresson commented 2 years ago

@Divyateja04 Sorry but this is a RN app and therefore you need some knowledge about RN to contribute to this repository.

thenicekat commented 2 years ago

Oh it's okay

mtalhabaig3 commented 1 year ago

@PierreBresson can i do it?

PierreBresson commented 1 year ago

Sure ;)

mtalhabaig3 commented 1 year ago

Alright! I am at it!

PierreBresson commented 1 year ago

@mtalhabaig3 well done, thanks a lot, it's merged 🙂

mtalhabaig3 commented 1 year ago

@PierreBresson no Problem 😊