Periodicity screen - Githubissues

NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.

https://nmf.earth

GNU General Public License v3.0

508 stars 157 forks source link

Periodicity screen #322

Closed PierreBresson closed 2 years ago

PierreBresson commented 3 years ago

[x] create screen
[x] display ClickableTags components see #324
[x] return user input values to Add Emission screen when user press confirm / or store input values in redux

Periodicity Selected-1

BatDroid commented 3 years ago

I can work on this :) just tell me from where the user can reach this screen (which I should create) :)

PierreBresson commented 3 years ago

@BatDroid thanks, I've assigned you :) The user can reach that screen from Add emission screen when clicking on Non-recurring (see https://github.com/NMF-earth/nmf-app/issues/254) and it should open as a modal - that's why there is cross button to close it)

BatDroid commented 3 years ago

@PierreBresson (I'll make this screen till you reply anyway) If I'm getting it correctly I suppose #254 needs to be done first. I mean, It seems in #254 the button which leads the user to the Periodicity screen happens. right? If yes then I suppose it's better that I work on both of them.

PierreBresson commented 3 years ago

Not really, #254 is just the listing of all the issues needed to complete the feature periodicity. Some work was done in #329 but it needs to be refactored into a component. Yes, clicking on Non-recurring in #254 is opening this periodicity screen

BatDroid commented 3 years ago

@PierreBresson I see, Then feel free to assign #315 & #321 to me as well.