search

NMF-earth / nmf-app

Understand and reduce your carbon footprint 🌱 iOS & Android.
https://nmf.earth
GNU General Public License v3.0
488 stars 157 forks source link

feat(date-touchable-button): added a icons to date touchable button #329

Closed Michelalmeidasilva closed 2 years ago

Michelalmeidasilva commented 2 years ago

✅ I have read the contributing file

Summary

Added two icons into TextButton Text Button #315

This pr added a calendar icon on the left and a green icon into right.

Observation: I didn't find the icon "calendar-number" in expo/vector-icons. So i have use the calendar icon instead.

Changelog

Addition of a row view around the three elements ( left icon, centerized text:"friday 8 october 2021", right icon).

Demo

image

PierreBresson commented 2 years ago

@Michelalmeidasilva thanks for the PR. Looks good but it needs to be turned into a component so it can also be used for the periodicity (see screenshot). For now you can only use 2 props, icon (left) & text. No need to make a component shared across the entire app, it can be place inside app/screens/AddEmission/components

PierreBresson commented 2 years ago

Closing in favor of https://github.com/NMF-earth/nmf-app/commit/81ac8dace7667eb8e77677a24108010d437f6cdc

PierreBresson commented 2 years ago

@Michelalmeidasilva thanks for submitting the PR, I have re-use your code to make the component ;)