Added full namespace to ClassInstance references for static Retrieve methods

NMFCode / NMF

This repository contains the entire code for the .NET Modeling Framework

BSD 3-Clause "New" or "Revised" License

36 stars 15 forks source link

Added full namespace to ClassInstance references for static Retrieve methods #52

Closed ChrisH07 closed 5 years ago

ChrisH07 commented 5 years ago

Fix for issue #51

georghinkel commented 5 years ago

Hm, I fear we are curing the symptoms rather than the root cause of the problem. Normally, the type reference should take part in the name conflict resolution that would automatically fully qualify the type reference in case of a conflict (see NamespaceGenerator.cs in CodeGen). Apparently, this does not work in this case.

But given that you have a concrete problem here, I will merge the changes for a quick fix and try to solve the actual problem in the next couple of days.

ChrisH07 commented 5 years ago

Hi Georg. I agree with you that this only solves a symptom and I didn't dig in to this problem deeply at all. If you would like I can provided a sample to reproduce the issue.

georghinkel commented 5 years ago

Yes, a sample would be greatly appreciated.