NMGRL / pychron

Data acquisition and processing framework for Ar-Ar geochronology and noble gas mass spectrometry
http://pychron.readthedocs.org/en/latest/
Apache License 2.0
26 stars 26 forks source link

outlier status incorrectly applied to integrated age #2104

Open mjz1983 opened 2 years ago

mjz1983 commented 2 years ago

When making data tables, outlier status (in the attached example, outlier on isochron) is being applied to the total integrated age. The total integrated age should include all steps. SMCN-01 hbl table.xlsx

jirhiker commented 2 years ago

This is a feature. you specify how the total integrated age should be calculated, all steps or all valid steps

mjz1983 commented 2 years ago

Ah. I might need a quick hand to show me how to turn on/off this feature.

Matt Zimmerer Field Geologist II New Mexico Bureau of Geology New Mexico Tech 801 Leroy Pl Socorro, NM 87801 @.*** 575.835.5114

On Jan 25, 2022, at 11:45 AM, Jake Ross @.***> wrote:

This is a feature. you specify how the total integrated age should be calculated, all steps or all valid steps

— Reply to this email directly, view it on GitHub https://github.com/NMGRL/pychron/issues/2104#issuecomment-1021497417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRMVZ3EFLNGWVO7L3ZBCHLUX3VTJANCNFSM5MZBNOCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.

mjz1983 commented 2 years ago

When the outlier steps are included in the total integrated age, those outlier steps are also used in the isochron calculation, which they shouldn't.

Is it possible to generate a data table where steps are omitted on the isochron, but include in the total integrated age?

MZ

On Tue, Jan 25, 2022 at 1:03 PM Matthew Zimmerer @.***> wrote:

Ah. I might need a quick hand to show me how to turn on/off this feature.

Matt Zimmerer Field Geologist II New Mexico Bureau of Geology New Mexico Tech 801 Leroy Pl Socorro, NM 87801 @.*** 575.835.5114

On Jan 25, 2022, at 11:45 AM, Jake Ross @.***> wrote:

This is a feature. you specify how the total integrated age should be calculated, all steps or all valid steps

— Reply to this email directly, view it on GitHub https://github.com/NMGRL/pychron/issues/2104#issuecomment-1021497417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRMVZ3EFLNGWVO7L3ZBCHLUX3VTJANCNFSM5MZBNOCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

jirhiker commented 2 years ago

The expected behavior is

cburrill commented 2 years ago

For the tables I think what we need is an option (check box) to use either the Total Integrated or Valid Integrated Age. Currently under the summary rows section, there is only the option for the Total Integrated age. So if steps are marked invalid and they are included on the table, they are currently being used in the integrated age and you need to change the integrated age manually or not include the invalid steps at all. I think the preference would be to show the invalid steps on the table but not have them included in any of the age calculations.

image

image

image

jirhiker commented 2 years ago

Don't know if this addresses your issue but the preferred age kind (Total Integrated, Valid Integrated) is set at the Group Age Node.

Screen Shot 2022-02-02 at 4 46 48 PM
cburrill commented 2 years ago

No, the correct option to change it isn't there. The age row changes whats in the summary where the plateau age goes. Even though I have "plateau else valid integrated age" in all the rows, it still shows "total integrated age" in the summary.

image