NMGRL / pychron

Data acquisition and processing framework for Ar-Ar geochronology and noble gas mass spectrometry
http://pychron.readthedocs.org/en/latest/
Apache License 2.0
26 stars 26 forks source link

ideogram plot button #268

Closed wcmcintosh closed 10 years ago

wcmcintosh commented 10 years ago

How about adding an ideogram plot button to the unknown pane?

jirhiker commented 10 years ago

I would like to hear the justification for such a button.

Placing it in the unknowns pane does not fit well with the current design.

jirhiker commented 10 years ago

selecting "New Ideogram" from the toolbar will use the current analyses in the unknowns pane but I don't see much utility in this.

wcmcintosh commented 10 years ago

Hi Jake:

Not sure what you are referring to regarding “New Ideogram”?

The reason for wanting a plot button somewhere on the unknown pane is to trigger a replot after tagging or adding or deleting analyses.  Am I correct that now you have to go to plot options from the unknown pane to trigger a replot?

Bill

William McIntosh Geochronologist/Volcanologist NM Bureau of Geology Associate Professor Earth and Environmental Science Dept NM Tech 801 Leroy Place Socorro, NM 87801 575-835-5271 mcintosh@nmt.edu

On Apr 3, 2014, at 2:20 PM, Jake Ross notifications@github.com wrote:

selected "New Ideogram" from the toolbar will use the current analyses in the unknowns pane but I don't see much utility in this.

— Reply to this email directly or view it on GitHub.

wcmcintosh commented 10 years ago

A replot button on the top bar would work just as well.

William McIntosh Geochronologist/Volcanologist NM Bureau of Geology Associate Professor Earth and Environmental Science Dept NM Tech 801 Leroy Place Socorro, NM 87801 575-835-5271 mcintosh@nmt.edu

On Apr 3, 2014, at 2:20 PM, Jake Ross notifications@github.com wrote:

selected "New Ideogram" from the toolbar will use the current analyses in the unknowns pane but I don't see much utility in this.

— Reply to this email directly or view it on GitHub.

jirhiker commented 10 years ago

Added a refresh plot action to the toolbar.

plot already refreshed when analyses deleted (and added?) Updated so that replot triggered when setting tags. (Already was the case if "filter invalid analyses" was checked when setting the tag but I fixed pychron so it will replot if "filter invalid analyses" not selected)

"New Ideogram" is a toolbar action that adds another Ideogram editor tab to the editor area.

wcmcintosh commented 10 years ago

Hi Jake;

Thanks for the extra refresh plot button.

On the save vs save as issue, save works fine in some circumstances, and as save as in others. 

Pychron restart may fix some of the funky behavior.

Bill

William McIntosh Geochronologist/Volcanologist NM Bureau of Geology Associate Professor Earth and Environmental Science Dept NM Tech 801 Leroy Place Socorro, NM 87801 575-835-5271 mcintosh@nmt.edu

On Apr 3, 2014, at 9:38 PM, Jake Ross notifications@github.com wrote:

Added a refresh plot action to the toolbar.

plot already refreshed when analyses deleted (and added?) Updated so that replot triggered when setting tags. (Already was the case if "filter invalid analyses" was checked when setting the tag but I fixed pychron so it will replot if "filter invalid analyses" not selected)

"New Ideogram" is a toolbar action that adds another Ideogram editor tab to the editor area.

— Reply to this email directly or view it on GitHub.

jirhiker commented 10 years ago

The decision to use "save or save as" only occurs if you a trying to "save" a figure that has not been saved to the database yet.

When you hit the save button pychron checks to see if the active editor has a value for save_figure_id. This variable is only set in two situations. 1) the user double clicks a saved figure from the "Saved Figures" Pane or the user does a "save as" of a figure.

The active editors save_figure_id is only cleared when you double click a sample.

Its not clear to me what "save works fine in some circumstances, and as save as in others" really means. Are you saying that selecting "save" still defaults to "save as" in some cases. If so this is to be expecting as I said if you are trying to save a figure that has not yet been saved.

In what circumstance does trying to "save" a saved figure still lead you to the "save as" dialog.